Move frame transformations to Tensor lib, add function to transform flux tensors to logical frame #5654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsvu
force-pushed
the
transform_tensor
branch
2 times, most recently
from
f5a932b
to
0481050
Compare
nilsdeppe
requested changes
Dec 11, 2023
| } | ||
|
|
||
| } // namespace | ||
|
|
||
| SPECTRE_TEST_CASE("Unit.PointwiseFunctions.GeneralRelativity.Transform", |
There was a problem hiding this comment.
I think you forgot to update the test name when you moved it in the first commit
| get<InputTags>(input), inv_jacobian)); | ||
| } | ||
|
|
||
| namespace Tags { |
There was a problem hiding this comment.
dox for the namespace and/or tag?
| typename TargetFrame, | ||
| typename ResultVars = Variables<tmpl::list< | ||
| Tags::TransformedFirstIndex<InputTags, SourceFrame>...>>> | ||
| ResultVars first_index_to_different_frame( |
There was a problem hiding this comment.
dox so it can be found in doxygen?
|
|
||
| template <typename... ResultTags, typename... InputTags, size_t Dim, | ||
| typename SourceFrame, typename TargetFrame> | ||
| void first_index_to_different_frame( |
nilsvu
force-pushed
the
transform_tensor
branch
from
0481050
to
9485983
Compare
|
Fixed, thanks for reviewing 👍 |
nilsdeppe
approved these changes
Dec 11, 2023
|
Merging now, @markscheel let me know if you have any comments on this and I can do a follow-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments