Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MortarSize hash and pup function to inbox tag #5658

Merged
merged 3 commits into from
Dec 8, 2023
Merged

Add MortarSize hash and pup function to inbox tag #5658

merged 3 commits into from
Dec 8, 2023

Conversation

nilsdeppe
Copy link
Member

Proposed changes

  • pup is needed for some type inference things so I don't have to write more code into Charm headers.
  • the hash is needed for having waitfree neighbor communication within a node.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsdeppe
Add pup function to inbox tag
1785733 
This is useful for nodegroup threading and type deduction. I.e. we "send" the
tag which allows us to implicitly deduce the type tag as a template parameter in
the threaded action.
@nilsdeppe
Combine test cases in Test_MortarHelpers.cpp
38505d0
@nilsdeppe
Add perfect hash for MortarSize
f07b511 
This is useful for non-atomic communication between neighboring elements since
this ensures that only 1 core can possible write into the hash table at once.
@nilsdeppe nilsdeppe requested a review from kidder December 8, 2023 03:57
@kidder kidder merged commit c500eee into sxs-collaboration:develop Dec 8, 2023
22 checks passed
@nilsdeppe nilsdeppe deleted the add_threading_1 branch April 11, 2024 03:19
@nilsdeppe nilsdeppe restored the add_threading_1 branch April 11, 2024 03:19
@nilsdeppe nilsdeppe deleted the add_threading_1 branch April 11, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kidder kidder kidder approved these changes

@wthrowe wthrowe wthrowe approved these changes

@nilsvu nilsvu nilsvu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nilsdeppe @nilsvu @wthrowe @kidder