Add a static single-producer single-consumer queue #5659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wthrowe
requested changes
Dec 8, 2023
src/Parallel/StaticSpscQueue.hpp
Outdated
| return try_emplace(std::forward<P>(v)); | ||
| } | ||
|
|
||
| /// Removes the first element from the queue and returns it. |
There was a problem hiding this comment.
This just returns it, doesn't remove.
kidder
requested changes
Dec 8, 2023
src/Parallel/StaticSpscQueue.hpp
Outdated
| std::array<T, capacity_ + 2 * padding_> data_{}; | ||
|
|
||
| // Align to cache line size in order to avoid false sharing | ||
| // readIndexCache_ and writeIndexCache_ is used to reduce the amount of cache |
src/Parallel/StaticSpscQueue.hpp
Outdated
| alignas(cache_line_size_) size_t write_index_cache_{0}; | ||
|
|
||
| // Padding to avoid adjacent allocations from sharing a cache line with | ||
| // writeIndexCache_ |
nilsdeppe
force-pushed
the
add_threading_2
branch
from
6fb73f8
to
2f52e9b
Compare
|
Thanks for the reviews! I rebased and just squashed the minor documentation changes. |
wthrowe
approved these changes
Dec 8, 2023
kidder
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This is needed for efficient intra-node data transfers when using a nodegroup DG element setup.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments