Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add truncate_* methods to ThreadsafeList #5663

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

wthrowe
Copy link
Member

@wthrowe wthrowe commented Dec 11, 2023

@nikwit Will this solve the memory problems for your function?

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@wthrowe
Copy link
Member Author

wthrowe commented Dec 11, 2023

Updated to strengthen one of the thread-safety guarantees.

Copy link
Contributor

@nikwit nikwit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good and solves my issue, thanks!

@knelli2 knelli2 merged commit 6585ad3 into sxs-collaboration:develop Dec 15, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants