Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch elliptic DG to a primal formulation #5667

Merged

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented Dec 13, 2023

Proposed changes

Handle auxiliary boundary corrections through a weak divergence rather than a Schur complement. This changes how Jacobians are applied on boundaries. It turns out this primal formulation is more stable when the Jacobians are large (for large outer boundaries).

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsvu
Copy link
Member Author

nilsvu commented Dec 13, 2023

@nilsdeppe this is the next PR in the series to fix the large outer boundaries. Can you review this one too?

Handle auxiliary boundary corrections through a weak divergence
rather than a Schur complement. This changes how Jacobians are applied
on boundaries, and it turns out the primal formulation is more stable
when the Jacobians are large (for large outer boundaries).
@nilsdeppe
Copy link
Member

Yep!

@nilsdeppe nilsdeppe merged commit 633a609 into sxs-collaboration:develop Dec 15, 2023
22 checks passed
@nilsvu nilsvu deleted the elliptic_primal_formulation branch December 15, 2023 21:12
@nilsvu nilsvu mentioned this pull request Dec 20, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants