Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine time and spatial derivative in spacetime_deriv_of_goth_g into… #5678

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

ncorsobh
Copy link
Contributor

… a spacetime derivative in function input.

Proposed changes

Currently spacetime_deriv_of_goth_g takes the time and spatial derivatives of the lapse as inputs and combines them into a spacetime derivative. We now plan to do this earlier in the process, so this part of the function is being removed.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@kidder kidder merged commit f9fa25a into sxs-collaboration:develop Jan 2, 2024
22 checks passed
@ncorsobh ncorsobh deleted the fix_goth_g branch January 3, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants