Support weak form in elliptic DG #5679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to use this with buffers that have tags other than Tags::div<FluxTags>. For example, the elliptic DG operator buffers the divergence directly in the output.
nilsvu
force-pushed
the
elliptic_weak_form
branch
2 times, most recently
from
e8697e0
to
1c80301
Compare
nilsdeppe
requested changes
Dec 16, 2023
| @@ -74,9 +78,19 @@ void InitializeGeometry<Dim>::operator()( | |||
| *inertial_coords = | |||
| element_map->operator()(*logical_coords, 0., functions_of_time); | |||
| // Jacobian | |||
| // Note: we can try to use `::dg::metric_identity_jacobian_quantities` here. | |||
| // When I tried (NV, Dec 2022) the DG residuals diverged on a sphere domain | |||
| for (size_t i = 0; i < lhs.size(); ++i) { | ||
| lhs[i] += 0.5 * rhs[i]; | ||
| lhs[i] += sign * 0.5 * rhs[i]; |
There was a problem hiding this comment.
[optional] consider precomputing sign * 0.5 outside the loop. That multiplication is 1/3 the FLOPS in this expression. At least a few years ago, compilers weren't doing that automatically :(
nilsvu
force-pushed
the
elliptic_weak_form
branch
from
1c80301
to
a6db1e0
Compare
nilsvu
force-pushed
the
elliptic_weak_form
branch
from
a6db1e0
to
2a1ea7b
Compare
nilsdeppe
approved these changes
Dec 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Almost gets the elliptic solver to work on large sphere domains! The attached
Lorentzian.yamlconfiguration works, only BBH ID needs some more treatment (next PR).Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments