Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to create a spacetime tensor from time and spatial ones. #5692

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

ncorsobh
Copy link
Contributor

@ncorsobh ncorsobh commented Jan 5, 2024

Proposed changes

The function combines the desired time component of a tensor with the desired spatial components of a tensor to produce one spacetime tensor. For instance, it could combine a time derivative with a spatial derivative to produce a spacetime derivative.

If there are locations throughout the code where this could be usefully applied to replace existing code, please suggest them!

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

src/DataStructures/Tensor/CreateView.hpp Outdated Show resolved Hide resolved
src/DataStructures/Tensor/CreateView.hpp Outdated Show resolved Hide resolved
src/DataStructures/Tensor/CreateView.hpp Outdated Show resolved Hide resolved
src/DataStructures/Tensor/CreateView.hpp Outdated Show resolved Hide resolved
tests/Unit/DataStructures/Tensor/Test_CreateView.cpp Outdated Show resolved Hide resolved
@ncorsobh ncorsobh force-pushed the make_spacetime_tensor branch 2 times, most recently from dd6e2e9 to ff6f4a5 Compare January 10, 2024 20:09
Copy link
Member

@wthrowe wthrowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Squash.

@wthrowe wthrowe merged commit 1d9e248 into sxs-collaboration:develop Jan 16, 2024
22 checks passed
@ncorsobh ncorsobh deleted the make_spacetime_tensor branch January 16, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants