Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Catch module on Wheeler #5695

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

knelli2
Copy link
Contributor

@knelli2 knelli2 commented Jan 8, 2024

The previous module was built in c++11 mode, but we need Catch in c++17 mode.

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

The previous module was built in c++11 mode, but we need Catch in c++17 mode.
@knelli2 knelli2 requested a review from nilsdeppe January 8, 2024 22:17
@knelli2 knelli2 added small Only changes a few lines of code, does a rename or is otherwise quick to review bugfix labels Jan 8, 2024
Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR :)

@nilsdeppe
Copy link
Member

Merging now since we can't check this in CI and tests aren't compiling on Wheeler :(

@nilsdeppe nilsdeppe merged commit 065bc25 into sxs-collaboration:develop Jan 8, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix small Only changes a few lines of code, does a rename or is otherwise quick to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants