Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ordering of IncludeCategories in clang-format #5699

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

ncorsobh
Copy link
Contributor

Proposed changes

A previous PR (#5690) had removed the duplicate entry of IncludeCategories in clang-format, assuming that the first one was being read. That assumption was incorrect, and the current version of IncludeCategories causes a conflict with the formatting options in clang-tidy. Although this version was added more recently to the file, it was decided that the other one was more preferable anyway, so this update switches the two. This removes the preference that pushes includes ending in .h to the beginning of the list.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@knelli2 knelli2 merged commit 7e5f17e into sxs-collaboration:develop Jan 11, 2024
22 checks passed
@knelli2
Copy link
Contributor

knelli2 commented Jan 11, 2024

Merging quickly so people can rebase and have clang-format work properly

@ncorsobh ncorsobh deleted the fix-clang-format branch January 12, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants