Fix ordering of IncludeCategories in clang-format #5699
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
A previous PR (#5690) had removed the duplicate entry of
IncludeCategories
inclang-format
, assuming that the first one was being read. That assumption was incorrect, and the current version ofIncludeCategories
causes a conflict with the formatting options inclang-tidy
. Although this version was added more recently to the file, it was decided that the other one was more preferable anyway, so this update switches the two. This removes the preference that pushes includes ending in.h
to the beginning of the list.Upgrade instructions
Code review checklist
make doc
to generate the documentation locally intoBUILD_DIR/docs/html
.Then open
index.html
.code review guide.
bugfix
ornew feature
if appropriate.Further comments