Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SettleToConstantQuaternion #5703

Merged

Conversation

geoffrey4444
Copy link
Contributor

Proposed changes

Add new function of time like SettleToConstant but for quaternions; the function of time always returned a unit quaternion (i.e., a rotation).

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please also fix the clang-tidy and compilation errors as well.

@geoffrey4444 geoffrey4444 self-assigned this Jan 17, 2024
Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, you can squash. (you can optionally wait for #5706 to be merged and rebase so the tests pass)

@geoffrey4444
Copy link
Contributor Author

Thanks again for the review, @knelli2 ! I squashed. A GrMhd test failure on gcc-9 release is unrelated to this PR (looks like tolerances might be too strict?)

@knelli2
Copy link
Contributor

knelli2 commented Jan 19, 2024

Test failures unrealted

@knelli2 knelli2 merged commit 494ca07 into sxs-collaboration:develop Jan 19, 2024
17 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants