Add IMEX ImplicitDenseOutput mutator #5711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsdeppe
approved these changes
Jan 21, 2024
|
Please hold off on merging. There is a bug somewhere in the IMEX dense output code that needs tracking down. I don't know if it in this PR or somewhere else. |
wthrowe
added
the
in progress
nilsdeppe
requested changes
Jan 23, 2024
Attempt to retrieve the step start in a time-stepper-agnostic way. Should work as long as we don't add single-stage methods that try to use FSAL or something.
IMEX needs to update from multiple histories for a single output.
wthrowe
force-pushed
the
imex/dense_output
branch
from
b859139
to
66ae841
Compare
|
I haven't figured out what's going on yet, but I'm pretty much convinced that it's not related to this code, so I think we can merge this. I've added a check that the dense output returned success and rebased on develop. |
wthrowe
removed
the
in progress
nilsdeppe
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments