Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an action for Klein-Gordon CCE worldtube data communication #5717

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

Sizheng-Ma
Copy link
Contributor

Proposed changes

This PR adds an action BoundaryComputeAndSendToEvolution<KleinGordonH5WorldtubeBoundary<Metavariables>, EvolutionComponent> to send worldtube data from the boundary component to the evolution component, together with two related unit tests.

Additionally, the action ReceiveWorldtubeData is hard-coded to take Metavariables::cce_boundary_communication_tags. In the first commit, I relax this assumption so that it can be used to treat Klein-Gordon data as well.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@Sizheng-Ma Sizheng-Ma force-pushed the wt_data_communication branch 2 times, most recently from b6ca832 to c7b6dec Compare February 10, 2024 19:59
@knelli2 knelli2 self-requested a review February 13, 2024 18:39
Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing I noticed

Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You can squash

@Sizheng-Ma
Copy link
Contributor Author

Done!

@knelli2 knelli2 added the auto-merge GitHub's auto-merge has been enabled for this PR. label Feb 19, 2024
@knelli2 knelli2 merged commit e750c5c into sxs-collaboration:develop Feb 19, 2024
22 checks passed
@Sizheng-Ma Sizheng-Ma deleted the wt_data_communication branch February 19, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge GitHub's auto-merge has been enabled for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants