Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instantiate inertial->distorted for strahlkorper_in_different_frame #5718

Conversation

geoffrey4444
Copy link
Contributor

@geoffrey4444 geoffrey4444 commented Jan 24, 2024

Proposed changes

For ringdown, we will need to transform Strahlkorpers from the ringdown inertial frame to the ringdown distorted frame. But strahlkorper_in_different_frame() currently assumes the initial frame is the grid frame. This PR adds support for transforming from the inertial frame to the distorted frame.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small things. You can squash directly

Comment on lines +83 to +84
throw std::runtime_error(
"Strahlkorper lies outside of distorted-frame region");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a change request because you're just copying what was already done in the file, but these should probably be converted to ERRORs at some point.

src/Domain/StrahlkorperTransformations.cpp Outdated Show resolved Hide resolved
@geoffrey4444 geoffrey4444 force-pushed the StrahlkorperTransformInertialToDistorted branch from bfeb959 to c46a79c Compare January 26, 2024 17:38
@nilsdeppe nilsdeppe merged commit 457c71c into sxs-collaboration:develop Jan 27, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants