Add CLI to plot size control diagnostics #5723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsvu
requested changes
Jan 31, 2024
| axes = list(axes) | ||
| # Damping times are sort of the odd ones out. Put it with control error but | ||
| # on a different y-axis | ||
| top1 = axes[0].plot(times, control_error, label="Control Error") |
There was a problem hiding this comment.
Does it make sense to plot abs(control_error) on a log scale?
There was a problem hiding this comment.
No, not really. I think we'd lose a lot of information about small oscillations that way.
There was a problem hiding this comment.
How so? You see small oscillations well on a log scale. I suggest trying a log scale, and/or plotting both. Anyway, this is up to you.
nilsvu
approved these changes
Feb 1, 2024
knelli2
force-pushed
the
plot_size_control
branch
from
de13e80
to
6d2237f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This is just a quick utility that plots most of the size control diagnostics necessary to quickly see what has gone wrong in a simulation. Not intended for a super detailed analysis, but you can change the x-range on the plot to zoom in on a specific time (and have the y-axes of all plots rescale accordingly)
To quickly plot size control diagnostics, try
This gives the result of SizeControlDiagA.pdf
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments