Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix oscillations in Heun2 IMEX dense output #5734

Merged

Conversation

wthrowe
Copy link
Member

@wthrowe wthrowe commented Feb 1, 2024

Also do a bunch of reorganization of the time-stepper test helpers.

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@teukolsky
Copy link
Contributor

In general, dense output only needs to be one order lower than the method itself, so from a theoretical point of view this linear interpolation should be fine.

nilsdeppe
nilsdeppe previously approved these changes Feb 8, 2024
Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to do the clang-tidy suggestions please squash right away or if you don't please go ahead and merge this PR :)

Some uses already have a pair, so let them pass it instead of forcing
unpacking.
Move some things out of the giant TimeStepperTestUtils.
More shrinking the giant TimeStepperTestUtils.
The quadratic output was highly oscillatory in IMEX evolutions.
@nilsdeppe nilsdeppe merged commit b4b1603 into sxs-collaboration:develop Feb 9, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants