-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add domain rendering script #5735
Conversation
3ed98e4
to
ec31754
Compare
It's working really well. Thanks for implementing this. The above output image is what I get when I fix the clip normal to Is this a paraview behavior or a bug is somewhere? |
Should be fixed (see fixup commit). Camera positioning is a bit tricky with ParaView... I'm sure this can be made more robust, but I think this is ok for a start. |
Checked the fixup solved issue. Please squash |
Shows elements and grid lines. This rendering is a starting point for visualizations of the domain geometry, e.g. for publications.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if you want to do anything about my suggestion. Not necessary though
camera.SetFocalPoint(*clip_origin) | ||
camera.SetPosition(*(np.array(clip_origin) + np.array(clip_normal) * 10.0)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This factor of 10 seems a bit arbitrary. I could imagine this not working for a BBH with an outer boundary of like 1000.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually ParaView ignores this factor, so I kept it at 10 :D It sets the zoom factor automatically to show the entire domain. As I said above, we can surely make the camera handling better here, but I haven't played around with it enough to understand what ParaView actually does with the camera.
Shows elements and grid lines. A second high-resolution dataset can be used to draw smooth element outlines. This rendering is a starting point for visualizations of the domain geometry, e.g. for publications.
For example:
Proposed changes
Upgrade instructions
Code review checklist
make doc
to generate the documentation locally intoBUILD_DIR/docs/html
.Then open
index.html
.code review guide.
bugfix
ornew feature
if appropriate.Further comments