Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminate parallel GMRES when it diverges #5742

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented Feb 6, 2024

Proposed changes

GMRES is guaranteed to decrease the residual monotonically, so it's an error when the residual increases.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

GMRES is guaranteed to decrease the residual monotonically,
so it's an error when the residual increases.
@nilsdeppe nilsdeppe merged commit 39ba007 into sxs-collaboration:develop Feb 8, 2024
22 checks passed
@nilsvu nilsvu deleted the gmres_diverge branch February 8, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants