Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TOV star test input file with more stable parameters. #5753

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

ncorsobh
Copy link
Contributor

Proposed changes

Updates the TOV star test input file to use isotropic coordinates and to use more appropriate constraint parameters.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

nilsdeppe
nilsdeppe previously approved these changes Feb 12, 2024
Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing these! A few questions/suggestions. Please let me know if you think they are a good idea or not :)

@ncorsobh
Copy link
Contributor Author

@nilsdeppe I added your suggested comments, I think they're a good idea. Since this is a very small PR I just squashed immediately

@nilsvu
Copy link
Member

nilsvu commented Feb 13, 2024

better move those comments up 1 line, so they comment on the line directly below them, rather than the line above them (that's how I read code at least) :)

@ncorsobh
Copy link
Contributor Author

@nilsvu Done. I changed the phrasing to make it even more explicit too

@knelli2
Copy link
Contributor

knelli2 commented Feb 16, 2024

@nilsvu Do you want to take another look at this?

@nilsvu nilsvu merged commit bcd33e5 into sxs-collaboration:develop Feb 17, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants