Introduce AMR policies #5765
Merged
Introduce AMR policies #5765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wthrowe
requested changes
Feb 14, 2024
| Isotropic /**< all dimensions must be refined the same */ | ||
| }; | ||
|
|
||
| /// Output operator for . |
| #include <pup_stl.h> | ||
|
|
||
| namespace amr { | ||
| Policies::Policies(amr::Isotropy isotropy) : isotropy_(isotropy) {} |
nilsvu
requested changes
Feb 15, 2024
nilsvu
approved these changes
Feb 16, 2024
Initially only holds the policy for the isotropy. Additional policies will be added in future PRs.
This gets rid of an unnecessary if constexpr as well as not needing to add the tag in executables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds
amr::Policies, a class that will allow run-time control over adaptive mesh refinement features.This PR adds the ability to control whether refinement is isotropic or anisotropic (i.e. whether each dimension can refine independently).
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments