Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out linear elliptic solver algorithm #5782

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented Feb 19, 2024

Proposed changes

Share lots of common code between elliptic executables. Helps with adding AMR.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsvu nilsvu force-pushed the linear_elliptic_solver branch 2 times, most recently from 1886e1e to 0a7502d Compare February 20, 2024 01:02
Get the tags from the system, instead of templating the
subdomain operator.
Share lots of common code between elliptic executables.
@kidder kidder merged commit 567e044 into sxs-collaboration:develop Feb 23, 2024
22 checks passed
@nilsvu nilsvu deleted the linear_elliptic_solver branch February 23, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants