Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an unchaged filtering extent in PerssonTci #5783

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

yoonso0-0
Copy link
Contributor

Proposed changes

A quick fix to a severe bug in #5779

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@yoonso0-0 yoonso0-0 added priority critical for progress small Only changes a few lines of code, does a rename or is otherwise quick to review labels Feb 19, 2024
nilsdeppe
nilsdeppe previously approved these changes Feb 19, 2024
@yoonso0-0
Copy link
Contributor Author

@knelli2 @nilsdeppe I pushed a fix for the test together. Basically adding one more test case that the second highest mode is excited but TCI only monitors the highest mode. This test would have flagged error for the previous mistake (keep using 1 not num_higest_modes in PerssonTci.cpp).

@yoonso0-0 yoonso0-0 removed the small Only changes a few lines of code, does a rename or is otherwise quick to review label Feb 19, 2024
Also updated test to have the previous unchanged version flag error.
@nilsdeppe nilsdeppe merged commit 2b464cb into sxs-collaboration:develop Feb 20, 2024
22 checks passed
@yoonso0-0 yoonso0-0 deleted the persson_fix branch February 20, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority critical for progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants