Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ocean charm module for move to C++20 #5806

Merged
merged 1 commit into from
Feb 25, 2024

Conversation

macedo22
Copy link
Contributor

Proposed changes

Since partially moving to C++20, SpECTRE doesn't build on ocean, but this new module fixes this

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@macedo22 macedo22 added priority critical for progress small Only changes a few lines of code, does a rename or is otherwise quick to review labels Feb 25, 2024
@knelli2 knelli2 self-requested a review February 25, 2024 07:55
Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to build unit tests and BBH exec on ocean with this. Ignoring unrelated test timeout

@knelli2 knelli2 merged commit 6dc9765 into sxs-collaboration:develop Feb 25, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority critical for progress small Only changes a few lines of code, does a rename or is otherwise quick to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants