Add AMR to elliptic executables #5817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsvu
force-pushed
the
amr_projectors_linsolv
branch
from
b8096d2
to
b55773d
Compare
nilsvu
changed the title
|
@kidder I updated this PR with adding AMR to the elliptic executables, and added a bunch of input file tests that enable AMR. I think these integration + regression tests are the strongest tests that everything is working together correctly. |
nilsvu
force-pushed
the
amr_projectors_linsolv
branch
7 times, most recently
from
91448cf
to
f7b7a93
Compare
kidder
previously approved these changes
Mar 12, 2024
|
though the tests are failing.... |
nilsvu
force-pushed
the
amr_projectors_linsolv
branch
from
f7b7a93
to
bd07030
Compare
The short name without namespaces can be ambiguous.
Resize buffers when needed.
nilsvu
force-pushed
the
amr_projectors_linsolv
branch
from
bd07030
to
55a5bd4
Compare
kidder
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Enables AMR for all elliptic executables!
Upgrade instructions
You'll have to add an
Amrsection to elliptic input files, as well as aPhaseChangeAndTriggerssection to trigger AMR. See the input files in this PR for examples.Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments