Fix OptimizerHacks for clang 17 #5823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsdeppe
added
priority
knelli2
requested changes
Mar 4, 2024
src/Utilities/OptimizerHacks.cpp
Outdated
Comment on lines
13
to
15
| && __clang_major__ < 17 && defined(__GLIBCXX__) | ||
| #include <string> | ||
| // clang v15+ fails to instantiate the following std library templates if |
There was a problem hiding this comment.
Update code comment as well?
wthrowe
requested changes
Mar 4, 2024
There was a problem hiding this comment.
It works with clang 16 without the hack now, so this is probably a change in SpECTRE, not a change in clang. I'd delete the whole section and see if it breaks for anyone.
Edit: Clang 15 fails to compile for unrelated reasons. (Duplicate Composition instantiations)
It seems like we don't need this anymore
|
Okay, deleted the code block. Thanks for reviewing! |
wthrowe
approved these changes
Mar 4, 2024
|
works for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments