Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new ExtendConnectivity functionality #5826

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

asaju7
Copy link
Contributor

@asaju7 asaju7 commented Mar 4, 2024

Proposed changes

Adds a new version of the ExtendConnectivity to work with Subcell in visualisations in SpECTRE. This PR adds most of the helpers that enable the new functionality. However, the current version of the function will only work for face neighbours (as defined in the connectivity DevGuide: #5825). Future versions will improve on this.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@asaju7 asaju7 force-pushed the ExtendConnectivityFaceNeighbours branch from e06e373 to df4fc9d Compare June 21, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant