Add tags for worldtube iterations #5847
Conversation
nikwit
force-pushed
the
iteration-tags
branch
2 times, most recently
from
0ac68f0
to
3c1b9b2
Compare
| struct Mass : db::SimpleTag { | ||
| using type = double; | ||
| using option_tags = tmpl::list<OptionTags::Mass>; | ||
| using type = std::optional<double>; |
There was a problem hiding this comment.
An idea to maybe avoid having to hold individual optionals in tags for self force things and check if they are available: You could just store the SelfForceOptions that were constructed from the input file in a tag. Then that tag can be used instead of ApplySelfForce (you just check the optional), and also wherever you need it's parameters. Thoughts?
There was a problem hiding this comment.
I removed ApplySelfForce now in favor of just checking whether MaxIterations is greater than 0. I think I would prefer to hide the extraction of these quantities in the OptionParsing, rather than having to get them from the struct each time step.
| */ | ||
| struct ApplySelfForce : db::SimpleTag { | ||
| using type = bool; | ||
| using option_tags = tmpl::list<OptionTags::ApplySelfForce>; | ||
| struct MaxIterations : db::SimpleTag { |
There was a problem hiding this comment.
With this change, you now implicitly convert a size_t to a bool wherever you had a check for ApplySelfForce. Could you change those to explicitly check if the size_t > 0? Also, depending on your thoughts about my other comment, this may be moot.
There was a problem hiding this comment.
Removed ApplySelfForce in fixup
| */ | ||
| struct InitializeCurrentIteration : tt::ConformsTo<db::protocols::Mutator> { |
There was a problem hiding this comment.
Did you want to add this to the executable?
There was a problem hiding this comment.
yes, it is added in #5855
|
@nikwit Could you give this a quick rebase just to run CI again? Otherwise it looks good and I'll merge it after CI finishes. |
Changes the self force options to an
Autoclass and introduces the tagsMaxIterationsandCurrentIterationwhich will be required for the iterative scheme of the worldtube.depends on #5831