Add 0th order acceleration terms #5860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knelli2
requested changes
Apr 19, 2024
Comment on lines
+47
to
+48
|
|
||
| DynamicBuffer<DataVector> temps(56, grid_size); |
There was a problem hiding this comment.
I think we want to have some guidelines regarding auto-generated code since it's not always the most optimal, just so we aren't baffled in 2 years when we look back at this. Could you
- Add a comment here saying that the following code was auto-generated using Mathematica (or Sympy, or whatever you used)
- If you have the code that generated this in a public repo/place, could you also add a comment pointing to it here? This way we can reproduce what you did.
- Take a cursory look at the auto-generated code and if you notice any quick/simple optimizations that can be made, make those and add a comment where you did so we can note the difference. (I tried to do a couple below)
There was a problem hiding this comment.
I added a description and a link to a new public repo. I incorporated your changes but do not think that all the changes need to be added in the comments, there are quite a few. A diff to the auto-generated file should show them.
src/Evolution/Systems/CurvedScalarWave/Worldtube/AccelerationTermsOrder0.cpp
Outdated
Show resolved
Hide resolved
src/Evolution/Systems/CurvedScalarWave/Worldtube/AccelerationTermsOrder0.cpp
Outdated
Show resolved
Hide resolved
src/Evolution/Systems/CurvedScalarWave/Worldtube/AccelerationTermsOrder0.cpp
Outdated
Show resolved
Hide resolved
src/Evolution/Systems/CurvedScalarWave/Worldtube/AccelerationTermsOrder0.cpp
Outdated
Show resolved
Hide resolved
knelli2
approved these changes
Apr 26, 2024
|
Thank you! |
knelli2
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The terms are added to the puncture field for non-geodesic orbits. They are described in Section IV of https://arxiv.org/abs/2403.08864.