Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not serialize compute items of a DataBox #5891

Merged
merged 3 commits into from
Mar 28, 2024
Merged

Do not serialize compute items of a DataBox #5891

merged 3 commits into from
Mar 28, 2024

Conversation

kidder
Copy link
Member

@kidder kidder commented Mar 27, 2024

Proposed changes

  • Do not serialize compute items of a DataBox
  • Allow a sizing PUP to succeed for non-owning VectorImpl (with a size of 0)
  • Test MemoryMonitor on a CompactBinaryObject Domain with ExportCoordinates. (This would trigger an ASSERT if done without the previous change.)

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@kidder
Only serialize mutable creation items in a DataBox
9358b0e 
Compute items can be recomputed.  Mutable subitems were already
reinitialized.
@kidder
Allow pup for sizing non-owning vectors
ca7002e 
Non-owning vectors will have a size of zero.
@kidder
Enable MemoryMonitor and checkpointing for ExportCoordinates
67733a3 
This tests using the memory monitor on the BinaryCompactObject
domain, which previously triggered an ASSERT when sizing a non-owning
vector.  Checkpointing is intentionally not done on CI, but also
previously triggered the same ASSERT.
@knelli2 knelli2 merged commit 9a905b0 into sxs-collaboration:develop Mar 28, 2024
22 checks passed
@kidder kidder deleted the checkpointing branch March 28, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knelli2 knelli2 knelli2 approved these changes

@nilsdeppe nilsdeppe nilsdeppe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kidder @nilsdeppe @knelli2