Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BinaryCompactObject domain: support initial Kerr horizon shape #5896

Merged
merged 7 commits into from
Apr 17, 2024
Merged

BinaryCompactObject domain: support initial Kerr horizon shape #5896

merged 7 commits into from
Apr 17, 2024

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented Mar 29, 2024 •
edited
Loading

Proposed changes

Allows to deform excision surfaces in the initial data to conform to spinning Kerr horizons.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsvu nilsvu force-pushed the update_id branch 2 times, most recently from f7e7adc to 2f0aabd Compare March 29, 2024 22:34
@nilsvu nilsvu requested a review from knelli2 March 29, 2024 22:35
@nilsvu nilsvu changed the title Tune initial data input file a little BinaryCompactObject domain: support initial Kerr horizon shape Mar 29, 2024
@nilsvu nilsvu force-pushed the update_id branch 2 times, most recently from b2f31be to 4a4506c Compare March 30, 2024 06:41
@nilsvu nilsvu force-pushed the update_id branch 4 times, most recently from 16fe7de to b683530 Compare April 12, 2024 22:32
knelli2
knelli2 reviewed Apr 15, 2024
View reviewed changes
Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple questions

src/Domain/Creators/BinaryCompactObjectHelpers.cpp Show resolved Hide resolved
src/Domain/Creators/BinaryCompactObjectHelpers.hpp Outdated Show resolved Hide resolved
knelli2
knelli2 approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You can squash

@nilsvu
Copy link
Member Author

nilsvu commented Apr 15, 2024

Done. Thanks for reviewing!

@knelli2 knelli2 merged commit c1d8200 into sxs-collaboration:develop Apr 17, 2024
22 checks passed
@nilsvu nilsvu deleted the update_id branch April 17, 2024 04:18
@knelli2 knelli2 added this to the BBH First Paper milestone May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knelli2 knelli2 knelli2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
BBH First Paper
Development

Successfully merging this pull request may close these issues.
2 participants
@nilsvu @knelli2