Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error if doing barycentric interpolation for FiniteDifference #5897

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

kidder
Copy link
Member

@kidder kidder commented Apr 1, 2024

Barycentric interpolation is unstable for finite difference. Lower-order interpolation should be used instead. Currently this is handled by IrregularInterpolant doing linear interpolation.

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

Barycentric interpolation is unstable for finite difference.  Lower-order
interpolation should be used instead.  Currently this is handled by
IrregularInterpolant doing linear interpolation.
@nilsdeppe nilsdeppe merged commit 9ec47a3 into sxs-collaboration:develop Apr 9, 2024
22 checks passed
@kidder kidder deleted the fd_regular_interp branch April 24, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants