Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pvpython support, specifically on mbot this is needed for the CLI #5906

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Fix pvpython support, specifically on mbot this is needed for the CLI #5906

merged 3 commits into from
Apr 12, 2024

Conversation

nilsdeppe
Copy link
Member

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsdeppe nilsdeppe requested a review from nilsvu April 10, 2024 14:23
@nilsdeppe
Fix paraview version finding
e819b7e 
Disables reading out paraview enviroment variables. However, whatever we were
trying to do is undocumented as far as I can tell.
@nilsvu nilsvu merged commit 1751591 into sxs-collaboration:develop Apr 12, 2024
22 checks passed
@nilsvu nilsvu added the build system CMake build system label Apr 12, 2024
@nilsdeppe nilsdeppe deleted the fix_pvpython_support branch August 6, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilsvu nilsvu nilsvu approved these changes

Assignees
No one assigned
Labels
build system CMake build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nilsdeppe @nilsvu