Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XCTS: add Robin outer boundary conditions #5915

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented Apr 17, 2024

Proposed changes

These allow to place the outer boundary at a much smaller outer radius R, since the error falls of as 1/R^2 rather than 1/R.

Here's a plot showing the faster convergence for BBH initial data:

daacdea2-275d-4b7b-95bc-47ecf770e045

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsvu nilsvu force-pushed the xcts_robin branch 3 times, most recently from c27d663 to 98f9438 Compare April 17, 2024 05:33
Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The clang-tidy errors look legitimate. You can squash immediately

*
* \snippet Elliptic/BoundaryConditions/Test_BoundaryCondition.cpp example_poisson_fields
* \snippet Elliptic/BoundaryConditions/Test_BoundaryCondition.cpp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the newline break rendering? I don't remember if we needed something special for snippet

WRAPPED_PUPable_decl_template(Robin);
/// \endcond

std::unique_ptr<domain::BoundaryConditions::BoundaryCondition> get_clone()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this and the boundary_condition_types to the cppto reduce hpp code? I doubt these are performance-critical to the point where the ability for the compiler to inline them helps

These allow to place the outer boundary at a much smaller
outer radius R, since the error falls of as 1/R^2 rather than 1/R.
@nilsdeppe nilsdeppe merged commit 4705616 into sxs-collaboration:develop Apr 19, 2024
22 checks passed
@nilsvu nilsvu deleted the xcts_robin branch April 19, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants