Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print available observations in CLI #5916

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Print available observations in CLI #5916

merged 1 commit into from
Apr 17, 2024

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented Apr 17, 2024

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsvu nilsvu requested a review from nilsdeppe April 17, 2024 18:11
nilsdeppe
nilsdeppe previously approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you very much!!!

knelli2
knelli2 requested changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are unhappy...

@nilsvu
Copy link
Member Author

nilsvu commented Apr 17, 2024

Yea there was a silly mistake

@knelli2 knelli2 merged commit b7c2426 into sxs-collaboration:develop Apr 17, 2024
22 checks passed
@nilsvu nilsvu deleted the list_obs branch April 17, 2024 20:25
@nilsvu nilsvu added the cli/pybindings Command line interface & Python bindings label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knelli2 knelli2 knelli2 approved these changes

@nilsdeppe nilsdeppe nilsdeppe left review comments

Assignees
No one assigned
Labels
cli/pybindings Command line interface & Python bindings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nilsvu @nilsdeppe @knelli2