Bookkeeping of hydro-mc coupling in packet evolution #5920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffoucart
commented
Apr 18, 2024
| @@ -94,10 +94,23 @@ SPECTRE_TEST_CASE("Unit.Evolution.Particles.MonteCarloEvolution", | |||
| std::array<DataVector, 2>{{zero_dv, zero_dv}}, | |||
| std::array<DataVector, 2>{{zero_dv, zero_dv}}}; | |||
|
|
|||
| // Set non-zero value that should nearly never lead | |||
| // to interaction, to get non-zero interaction terms. | |||
There was a problem hiding this comment.
I'll update the comment after code review -- but in fact, due to the use of a minimum value of 1.e-100 in the RNG when determining the time to the next event, we are explicitly guaranteed that no scattering / absorption will happen.
ffoucart
force-pushed
the
MCCouplingEvolvePacket
branch
from
6c38e72
to
13002ef
Compare
kidder
requested changes
Apr 30, 2024
| void draw_single_packet(gsl::not_null<double*> time, | ||
| gsl::not_null<std::array<double, 3>*> coord, | ||
| gsl::not_null<std::array<double, 3>*> momentum, | ||
| gsl::not_null<std::mt19937*> random_number_generator); | ||
| } // namespace detail | ||
|
|
||
|
|
||
| // Contribution to the neutrino-matter coupling terms from |
There was a problem hiding this comment.
Make this a doxygen comment with the first sentence as \brief and the rest as \details
ffoucart
force-pushed
the
MCCouplingEvolvePacket
branch
from
13002ef
to
3af7643
Compare
kidder
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add computation of coupling between MC packet and fluid variables in EvolvePacketInElement. This is only bookkeeping for now, and not used to feedback on the fluid. We will also need to add contribution from the packets using the diffusion approximation after merging #5851
Upgrade instructions
None
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.