Normalize subfile path in H5 lib #5924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsvu
force-pushed
the
normalize_subfile_path
branch
from
43b7c03
to
014060e
Compare
knelli2
requested changes
Apr 23, 2024
There was a problem hiding this comment.
@nilsdeppe Could you take a quick look at this? I want to merge this before #5919 because it's used in there
Comment on lines
+397
to
+398
| if (path.front() != '/') { | ||
| path = '/' + path; |
There was a problem hiding this comment.
Can you add a test of this normalization in the c++ tests?
This has bothered me for a long time. A leading slash and _no_ extension for subfile names was required before, and failing to do this lead to rather useless error messages. Now, the leading slash and the extension are handled within the H5 lib, so it should be much easier to use.
nilsvu
force-pushed
the
normalize_subfile_path
branch
from
014060e
to
78bc61d
Compare
|
No need to wait for explicit approval from me. |
knelli2
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has bothered me for a long time. A leading slash and no extension for subfile names was required before, and failing to do this lead to rather useless error messages. Now, the leading slash and the extension are handled within the H5 lib, so it should be much easier to use.
Proposed changes
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments