Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rebase issue from #5877 #5925

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

knelli2
Copy link
Contributor

@knelli2 knelli2 commented Apr 19, 2024

Proposed changes

This was my bad. Merged #5877 too quickly.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@knelli2 knelli2 added the priority critical for progress label Apr 19, 2024
@knelli2 knelli2 requested a review from wthrowe April 19, 2024 00:21
@knelli2 knelli2 added the bugfix label Apr 19, 2024
Copy link
Member

@wthrowe wthrowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The include is unused and misformatted. Just delete it.

@knelli2
Copy link
Contributor Author

knelli2 commented Apr 19, 2024

The commented code won't compile without it if somebody tries it. Should we just keep it, but with the proper formatting?

@wthrowe
Copy link
Member

wthrowe commented Apr 19, 2024

There shouldn't be a giant block of commented code either, but I wasn't going to ask you to fix that in this PR.

@knelli2
Copy link
Contributor Author

knelli2 commented Apr 19, 2024

@wthrowe Ok I just removed it

@wthrowe
Copy link
Member

wthrowe commented Apr 19, 2024

Filed #5926 for the commented code.

@wthrowe wthrowe enabled auto-merge April 19, 2024 05:54
@wthrowe wthrowe merged commit 1c32b58 into sxs-collaboration:develop Apr 19, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix priority critical for progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants