Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI command to plot elliptic solver convergence #5929

Merged

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented Apr 19, 2024

Proposed changes

Example:

convergence

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

Comment on lines +96 to +97
label="Linear residual" if i == 0 else None,
marker="." if len(residuals) < 20 else None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just always have a marker?

Copy link
Member Author

@nilsvu nilsvu Apr 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's too busy if you have so many markers that you can't distinguish them anymore. And inversely, you should have markers if the line has visible kinks. So 20 seems like a reasonable but fairly arbitrary value in between.

@nilsdeppe nilsdeppe merged commit b7cf728 into sxs-collaboration:develop Apr 23, 2024
22 checks passed
@nilsvu nilsvu deleted the plot_ellsolver_convergence branch April 23, 2024 22:19
@nilsvu nilsvu added the cli/pybindings Command line interface & Python bindings label May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli/pybindings Command line interface & Python bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants