Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BBH ID: compute initial orbital params from PN #5933

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented Apr 23, 2024

Proposed changes

Port parts of SpEC's ZeroEccParamsFromPN.py to set initial orbital parameters for circular orbits. Two functions from SpEC are just imported, and should be modernized later. This allows to generate near-circular ID like this:

spectre bbh generate-id -o ./test -q 1 --chi-A 0 0 0 --chi-B 0 0 0 --eccentricity 0 --num-orbits 20

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

These can be used until we have ported them to SpECTRE.
Free up '-e' for use as 'eccentricity'.
@nilsvu nilsvu changed the title BBH initial data: compute initial orbital params from PN BBH ID: compute initial orbital params from PN Apr 23, 2024
Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A few minor suggestions that I'm not sure are reasonable. Please squash if you decide to do them!

support/Pipelines/Bbh/InitialData.py Show resolved Hide resolved
support/Pipelines/Bbh/InitialData.py Outdated Show resolved Hide resolved
support/Pipelines/Bbh/InitialData.py Outdated Show resolved Hide resolved
support/Pipelines/Bbh/InitialData.py Show resolved Hide resolved
"Time to merger. Specify together with a zero eccentricity to compute"
" initial orbital parameters for a circular orbit."
),
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While adding these, I'm not sure how much of an effect tidal deformability has for including matter terms. @moble @ffoucart do you know what SpEC does for NSNS initial parameters? Just assume BHs?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main difference would be in the estimated number of orbits to merger. The current initial data just uses the BBH formula at a fixed distance. We do have an estimate of the number of orbits that includes some correction from the BBH formula, but I don't recall whether it's used at all in current automation. @tiamartineau would know.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, thank you! I'm just curious for the future, I don't think this should be worried about in this PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...ah, ignore my first comment, thought you were talking about the orbits to eccentricity reduction, not merger-- the answer is no, not yet.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, that's @tiamartineau !!

Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though GCC has the tests failing. Please squash!

@nilsdeppe nilsdeppe merged commit aabde07 into sxs-collaboration:develop Apr 26, 2024
22 checks passed
@knelli2 knelli2 added this to the Eccentricity Control milestone May 8, 2024
@nilsvu nilsvu deleted the ecc_pn branch June 6, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants