Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune BBH ID input file a little #5940

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented Apr 24, 2024

  • Don't need the h-refinement in the outer shell anymore with Robin boundary conditions.
  • Also set DG penalty parameter to a safer value of 1.5.

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

- Don't need the h-refinement in the outer shell anymore with
  Robin boundary conditions.
- Also set DG penalty parameter to a safer value of 1.5.
@nilsdeppe nilsdeppe merged commit 0a69427 into sxs-collaboration:develop Apr 26, 2024
22 checks passed
@nilsvu nilsvu deleted the tune_id branch April 26, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants