Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unconstrain numpy version #5962

Merged
merged 1 commit into from
May 5, 2024
Merged

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented May 2, 2024

Proposed changes

Looks like the segfault we got in #3844 was fixed in newer versions of numpy. Closes #3844.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsvu nilsvu requested a review from kidder May 2, 2024 16:56
kidder
kidder previously approved these changes May 2, 2024
Looks like the segfault we got was fixed in newer versions of numpy.
@nilsdeppe nilsdeppe merged commit c4864ba into sxs-collaboration:develop May 5, 2024
22 checks passed
@nilsvu nilsvu deleted the numpy_version branch May 5, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segfaults with Numpy 1.22+
3 participants