Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Sarah Habib to metadata #5965

Merged
merged 1 commit into from
May 3, 2024
Merged

Add Sarah Habib to metadata #5965

merged 1 commit into from
May 3, 2024

Conversation

shabibti
Copy link
Contributor

@shabibti shabibti commented May 3, 2024 •
edited
Loading

🙂

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@shabibti shabibti requested a review from knelli2 May 3, 2024 17:34
@yoonso0-0
Copy link
Contributor

🎉

nilsvu
nilsvu approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@nilsvu nilsvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@nilsvu nilsvu merged commit 2c4f624 into sxs-collaboration:develop May 3, 2024
22 checks passed
@shabibti shabibti deleted the UpdateMetadata branch May 20, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilsvu nilsvu nilsvu approved these changes

@knelli2 knelli2 knelli2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shabibti @yoonso0-0 @nilsvu @knelli2