Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix beginners guide docker instruction #5975

Merged
merged 1 commit into from
May 8, 2024

Conversation

knelli2
Copy link
Contributor

@knelli2 knelli2 commented May 8, 2024

Since we changed the demo container so that the entry point is the
CLI, this broke the instructions on the tutorial page. Adding
--entrypoint "/bin/bash" fixes this.

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

Since we changed the demo container so that the entry point is the
CLI, this broke the instructions on the tutorial page. Adding
`--entrypoint "/bin/bash"` fixes this.
@knelli2 knelli2 requested a review from MarloMo May 8, 2024 17:59
Copy link
Contributor

@MarloMo MarloMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for the fix!

@nilsvu nilsvu enabled auto-merge May 8, 2024 18:11
@nilsvu nilsvu merged commit 1bd361d into sxs-collaboration:develop May 8, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants