Mc high ka corrections #5977
Merged
Mc high ka corrections #5977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #5902 |
ffoucart
force-pushed
the
MCHighKaCorrections
branch
2 times, most recently
from
10bc6dc
to
c8c0f92
Compare
ffoucart
force-pushed
the
MCHighKaCorrections
branch
2 times, most recently
from
7424311
to
0939cef
Compare
|
Rebased against 5902 and ready for review. |
kidder
requested changes
Jun 4, 2024
| #include <array> | ||
|
|
||
| #include "Evolution/Particles/MonteCarlo/NeutrinoInteractionTable.hpp" | ||
| #include "Evolution/Particles/MonteCarlo/TemplatedLocalFunctions.hpp" |
There was a problem hiding this comment.
make this the first include followed by a blank line
| // d(radiation_energy_density)/d(fluid_energy_density) | ||
| // at constant Ye, and | ||
| // d(neutrino_lepton_number_density)/d(proton_number_density) | ||
| // at constant T as measured of how 'impactfull' neutrino |
ffoucart
force-pushed
the
MCHighKaCorrections
branch
2 times, most recently
from
5f00b37
to
a52c6fa
Compare
ffoucart
force-pushed
the
MCHighKaCorrections
branch
from
a52c6fa
to
37e1856
Compare
kidder
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add corrections to high absorption opacity regions needed for implicit Monte-Carlo
Upgrade instructions
NA
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.