Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign step/slab size changing #5999

Merged
merged 16 commits into from
Jul 11, 2024

Commits on Jul 8, 2024

  1. Configuration menu
    Copy the full SHA
    105ffcf View commit details
    Browse the repository at this point in the history
  2. Avoid potential roundoff problems in test times

    Using powers of two also matches what we do in almost all cases in an
    actual evolution.
    wthrowe committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    abf810d View commit details
    Browse the repository at this point in the history
  3. Switch to symmetric computation of Time::value()

    The detailed roundoff behavior shouldn't matter in the regimes we care
    about, but the symmetric form is convenient for tests where negating
    all the inputs now exactly negates the output.
    wthrowe committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    200262c View commit details
    Browse the repository at this point in the history
  4. Add TimeStepRequest struct

    wthrowe committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    818f671 View commit details
    Browse the repository at this point in the history
  5. Add TimeStepRequestProcessor

    wthrowe committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    3534e7f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    422430e View commit details
    Browse the repository at this point in the history
  7. Use TimeStepRequest in StepChoosers

    This does not change the StepChoosers to use new features of the
    interface, although the new slab-size goal can come into effect with
    the LimitTimeStep control system action (as desired).
    wthrowe committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    38a22bc View commit details
    Browse the repository at this point in the history
  8. Ignore argument sign in Constant StepChooser

    Instead of making people figure out which to pass for backwards
    evolutions, just accept either.
    wthrowe committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    5a9315d View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    32ce1f9 View commit details
    Browse the repository at this point in the history
  10. Use new features in PreventRapidIncrease

    * Do nothing when not active
    * Don't set limit as a new goal
    wthrowe committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    2bad6e1 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    17d5db6 View commit details
    Browse the repository at this point in the history
  12. Remove roundoff-handling from Times trigger

    StepToTimes no longer has roundoff problems.
    wthrowe committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    884f7c5 View commit details
    Browse the repository at this point in the history
  13. Rename Increase to LimitIncrease, only limit step

    Much more common operation than an unconditional size increase.
    wthrowe committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    f31b0cb View commit details
    Browse the repository at this point in the history
  14. Add Maximum StepChooser

    Like Constant, but will not increase the step size if it is not being
    changed for other reasons.
    
    Most appearances of Constant in the examples were not useful, so
    removed instead of kept or replaced.
    wthrowe committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    a6f47a7 View commit details
    Browse the repository at this point in the history
  15. Make StepChooser help wording uniform

    Always clearly indicate whether the class provides a goal or a limit.
    wthrowe committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    6666bd7 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Configuration menu
    Copy the full SHA
    5061e65 View commit details
    Browse the repository at this point in the history