Document the CCE example input file #6015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsdeppe
force-pushed
the
cce_tutorial_and_input_file
branch
from
a2eefa9
to
8b65d43
Compare
keefemitman
reviewed
May 21, 2024
| StepChoosers: | ||
| - Constant: 0.5 | ||
| - Constant: 0.5 # Don't take steps bigger than 0.5M |
There was a problem hiding this comment.
We might want to lower this to 0.1 for production runs.
There was a problem hiding this comment.
Okay, I'll decrease it! We hopefully can have the tests not time out with that so then we can just have the sample not require changes for production :)
knelli2
requested changes
May 21, 2024
Comment on lines
143
to
146
| # How often per CCE time step to output. Given the tight default tolerances of | ||
| # 1e-6 with an Adams-Bashforth stepper, once per time step is probably fine. | ||
| ScriOutputDensity: 1 |
There was a problem hiding this comment.
@keefemitman Is this often enough for waveform analysis? I don't have an intuition on what we need
There was a problem hiding this comment.
1 seems to be fine for the majority of runs I've looked at
nilsdeppe
force-pushed
the
cce_tutorial_and_input_file
branch
from
8b65d43
to
9ad853d
Compare
|
I've rebased and squashed changes. Thanks for the reviews! |
This is to help people like me who don't know what anything means actually be able to change things in a meaningful way.
nilsdeppe
force-pushed
the
cce_tutorial_and_input_file
branch
from
9ad853d
to
a583b01
Compare
|
Whoops! Done, thanks! |
knelli2
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This is to help people like me who don't know what anything means actually be able to change things in a meaningful way.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments