Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add increasing_substep_time_steppers list #6021

Merged

Conversation

wthrowe
Copy link
Member

@wthrowe wthrowe commented May 22, 2024

Necessary property for worldtube particle tracking.

Not a huge fan of the name, so if anyone has a better idea feel free to suggest. Unfortunately, I've already used "monotonic" for a different property.

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@wthrowe wthrowe mentioned this pull request May 22, 2024
3 tasks
Avoid incoming ambiguity.
The lists are in the same namespace as the classes.  Makes things much
shorter.
Necessary property for worldtube particle tracking.
@wthrowe wthrowe force-pushed the increasing_substep_time_steppers branch from 0b3d966 to fdc2269 Compare May 22, 2024 23:25
@knelli2
Copy link
Contributor

knelli2 commented May 23, 2024

What is the other property that "monotonic" is used for? Is it really that bad if you use it again?

@wthrowe
Copy link
Member Author

wthrowe commented May 23, 2024

The AdamsMoultonPcMonotonic class and TimeStepper::monotonic() function refer to the "not deadlocking the control system" property.

@knelli2
Copy link
Contributor

knelli2 commented May 23, 2024

Hmm yeah probably shouldn't overload the meaning. However, it seems like using "monotonic" in this PR makes more sense and the other names should be changed to something else

@wthrowe
Copy link
Member Author

wthrowe commented May 23, 2024

Do you have a suggestion for the other one, then?

The two properties are, explicitly:

  1. Time is non-decreasing for all operations (but substep times can repeat)
  2. Substep time is strictly increasing (but things like dense-output time can decrease freely)

@knelli2
Copy link
Contributor

knelli2 commented May 24, 2024

Oh wow ok... Yeah I don't have a good idea how to differentiate these. They are so similar in many ways but just slightly different. I guess increasing_substep_time_steppers is ok for now.

@knelli2 knelli2 merged commit a6a255e into sxs-collaboration:develop May 24, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants