Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status CLI: remove some backwards compatibility #6022

Merged
merged 1 commit into from
May 25, 2024

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented May 23, 2024

This line raised permission errors if the directory isn't readable. We don't need this backwards compatibility anymore (it's been 8 months), so just delete it.

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

This line raised permission errors if the directory
isn't readable. We don't need this backwards
compatibility anymore (it's been 8 months), so just delete it.
@knelli2 knelli2 merged commit 1d1cff3 into sxs-collaboration:develop May 25, 2024
22 checks passed
@nilsvu nilsvu deleted the fix_status branch May 25, 2024 19:40
@nilsvu nilsvu added the cli/pybindings Command line interface & Python bindings label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli/pybindings Command line interface & Python bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants