Add 3D EoS test helper and fix bug in 2d random generators #6030
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds a EoS Test helper for 3-d EoSs, and fixes what I believe to have been a bug in the 2-d EoS test helpers where the specific energy random generators was not being used correctly.
Upgrade instructions
Code review checklist
make doc
to generate the documentation locally intoBUILD_DIR/docs/html
.Then open
index.html
.code review guide.
bugfix
ornew feature
if appropriate.Further comments
The 3D EoS test helper is essentially a pared-down version of the 2D helper (because we require fewer thermodynamic functions to be implemented for the 3D EoSs) though we work in terms of randomly generated temperatures. In general, random tests should probably be implemented with respect to rest mass density, temperature, and electron fraction, rather than the specific internal energy, because it is hard to determine the valid range for the specific internal energy but it's typically very easy for the temperature.