Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3D EoS test helper and fix bug in 2d random generators #6030

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

isaaclegred
Copy link
Contributor

Proposed changes

This PR adds a EoS Test helper for 3-d EoSs, and fixes what I believe to have been a bug in the 2-d EoS test helpers where the specific energy random generators was not being used correctly.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

The 3D EoS test helper is essentially a pared-down version of the 2D helper (because we require fewer thermodynamic functions to be implemented for the 3D EoSs) though we work in terms of randomly generated temperatures. In general, random tests should probably be implemented with respect to rest mass density, temperature, and electron fraction, rather than the specific internal energy, because it is hard to determine the valid range for the specific internal energy but it's typically very easy for the temperature.

@nilsdeppe
Copy link
Member

Please go ahead and squash :) I have no idea how clang-tidy is deciding these things. It seems to be wrong for the header file...

@isaaclegred
Copy link
Contributor Author

@nilsdeppe (possibly) modulo the clang-tidy errors I think this is ready to go

@nilsdeppe nilsdeppe merged commit d220f12 into sxs-collaboration:develop Jul 7, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants