Add SendDataToElement action for nodegroup elements #6041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kidder
requested changes
May 31, 2024
| // and the nodegroup by using `db::get_mutable_reference`. If/when we | ||
| // start dynamically inserting and removing elements, we'll need to update | ||
| // how we handle this. For example, we might need the containers to have | ||
| // strongly stability guarantees. |
| // exact minimum number of sends we need to do, but gets us close in most | ||
| // cases. If we really wanted to we could also add the number of | ||
| // directions that don't have external boundaries in our neighbors block. | ||
| // if (count >= |
There was a problem hiding this comment.
did you mean to leave this if commented out?
There was a problem hiding this comment.
Yes, because this is the bookkeeping code I talked with Will about to minimize communication. I want to get the rest in before I get the counting sorted out completely :)
nilsdeppe
force-pushed
the
add_threading_16
branch
from
722524c
to
67e2b1a
Compare
|
Rebased and squashed. Thanks for the review! |
kidder
approved these changes
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments